WaveStar Logo

spell2007
Collated Comments for Review

Page
/Line
By Comments & Responses Id
1/15 R #0: Brian - 15,16, 17 - Lines before { (6/19/2007) --lvallone  0
A Disagree
1/15 R #1: Brian - No ";" (6/19/2007) --lvallone  1
A Disagree
1/15 R #24: John - Spelling should be spelling. (6/19/2007) --lvallone  2
A Agree change comment on Line 7
1/15 R #25: John - no return type declared. (6/19/2007) --lvallone  3
A Minor Defect- will add return type
1/15 R #36: Kapil - "Spelling" should be "spelling" (6/19/2007) --lvallone  4
A same as 2
1/15 R #37: Kapil - arguments are undeclared (6/19/2007) --lvallone  5
A Disagree
1/15 R #16: Steve - redefine Spelling as "bool" (ie return value type) (6/19/2007) --lvallone  6
A Disagree
1/16 R #38: Kapil - declarations on line 16 & line 17 should be before line 15. (6/19/2007) --lvallone  7
A Disagree
1/16 R #17: Steve - move argument declarations to after "{" (6/19/2007) --lvallone  8
A Disagree
1/20 R #26: John - type error, used as bool throughout the code. (6/19/2007) --lvallone  9
A Disagree
1/20 R #39: Kapil - YourError - needs to define variable type. (6/19/2007) --lvallone  10
A Disagree
1/20 R #18: Steve - Redefine YourError as boolean (e.g. bool YourError;)As a result, change "i," declaration to "i;" &"Length" to "int Length" (6/19/2007) --lvallone  11
A Disagree
1/25 R #27: John - Flag used as bool thoughtout the code, declared as unsigned int (6/19/2007) --lvallone  12
A Disagree
1/25 R #40: Kapil - unsigned Flag, need to define variable type. (6/19/2007) --lvallone  13
A Disagree
1/25 R #19: Steve - change "unsigned" to "bool" (6/19/2007) --lvallone  14
A Disagree
1/28 R #11: Ron - YourError defined as int, being assigned a Boolean value (6/19/2007) --lvallone  15
A Disagree
1/30 R #2: Brian - "Test" undefined (6/19/2007) --lvallone  16
A Agree - will define Test in variable declaration section
1/30 R #28: John - test undefined. (6/19/2007) --lvallone  17
A same as 16
1/30 R #41: Kapil - Test undefined. (6/19/2007) --lvallone  18
A same as 16
1/30 R #9: Mike - Test not declared. (6/19/2007) --lvallone  19
A same as 16
1/30 R #12: Ron - "Test" never defined. (6/19/2007) --lvallone  20
A same as 16
1/30 R #20: Steve - Test undefined. Declare inline? (e.g. "int Test = 0;") (6/19/2007) --lvallone  21
A same as 16
1/31 R #29: John - Dangerous. Needs to be initialized before use below. Suggest initializing to "new char[5]" instead of '/0' (6/19/2007) --lvallone  22
A Agree - will initialize an array to store the ASCII numbers
1/31 R #8: Mike - set to '0' which is ASCII for NULL should be set to '48' (Ed note - believe this is referring to initialization of SpellNumber) (6/19/2007) --lvallone  23
A Disagree - agreement with Mike that no change is required
1/32 R #7: Mike - N set to 1000, limits input integer to 0-9999 (6/19/2007) --lvallone  24
A Agree - will change N to 10,000
1/49 R #30: John - Missing '*' to close comment. (6/19/2007) --lvallone  25
A Agree - will add missing * to correct comment close
1/49 R #4: Mike - Comment at end of line 49 does not contain a '*/', causes the following line to be commented out. (6/19/2007) --lvallone  26
A same as 25
1/49 R #14: Ron - Comment not closed. (6/19/2007) --lvallone  27
A same as 25
1/49 R #21: Steve - correct unclosed comment "*/" (6/19/2007) --lvallone  28
A same as 25
1/51 R #42: Kapil - spelledNumber should be *spelledNumber (6/19/2007) --lvallone  29
A Disagree
1/51 R #13: Ron - SpelledNumber[i]=Test; SpelledNumber is a char and should be treated as an array, also may cause a type mismatch since Test is an integer and SpelledNumber[i] is looking for a character. (6/19/2007) --lvallone  30
A Disagree
1/55 R #10: Mike - 55-59, logic seems flawed, not sure of fix, but counting seems to be backwards. (6/19/2007) --lvallone  31
A Disagree - walked through logic, no defect found
1/55 R #6: Mike - else statement needs brackets (6/19/2007) --lvallone  32
A Disagree
1/57 R #3: Brian - SpelledNumber mis-spelled (6/19/2007) --lvallone  33
A Agree - will correct spelling of SpeledNumber
1/57 R #31: John - SpeledNumber mispelled. (6/19/2007) --lvallone  34
A same as 33
1/57 R #43: Kapil - speledNumber should be spelledNumber (6/19/2007) --lvallone  35
A same as 33
1/57 R #5: Mike - Speled number should be spelled number (6/19/2007) --lvallone  36
A same as 33
1/57 R #15: Ron - variable SpeledNumber, spelled incorrectly. (6/19/2007) --lvallone  37
A same as 33
1/58 R #22: Steve - SpeledNumber is misspelled, should be SpelledNumber. (6/19/2007) --lvallone  38
A same as 33
1/64 R #32: John - Sets last elements used to null. Remove, because it will also exceed the array size as mentioned above. (6/19/2007) --lvallone  39
A Agree - will change array size to 6 (see item #22)
1/65 R #33: John - check if strcpy is included. (6/19/2007) --lvallone  40
A Agree - need to pull in <string.h>
1/65 R #34: John - variables referenced backwards. Destination variable is first, followed by source. (6/19/2007) --lvallone  41
A Agree - will switch variables
1/65 R #23: Steve - should be strcpy(*SpelledNumber, Somestring);i.e. reference content of address pointed to by SpelledNumber & add space after comma. (6/19/2007) --lvallone  42
A Disagree
1/66 R #35: John - return inconsistent with usage above. (6/19/2007) --lvallone  43
A Disagree
 
Key
SymbolMeaning
RReviewer
AAuthor
MModerator

The number at the start of each comment is the physical line number of the comment. This number will not change as comments are added or revised. The id shown in the last column is the logical id number assigned. This number may change as comments are added.

Login | My Reviews

This page was generated on hosol109 on Tue Jun 19 11:26:55 EDT 2007 using the script
/usr/local/suitespot/docs/cgi-bin/Xreview/revcollate.pl.

xtreme-dwdm.web.lucent.com
Webmaster: email